34 lines
1.3 KiB
Diff
34 lines
1.3 KiB
Diff
From fee96422e6f0056561cf74fef2012cc066c9db86 Mon Sep 17 00:00:00 2001
|
|
From: "Miss Islington (bot)"
|
|
<31488909+miss-islington@users.noreply.github.com>
|
|
Date: Wed, 2 Jun 2021 21:23:40 -0700
|
|
Subject: [PATCH] bpo-44022: Improve the regression test. (GH-26503) (GH-26507)
|
|
|
|
It wasn't actually detecting the regression due to the
|
|
assertion being too lenient.
|
|
(cherry picked from commit e60ab843cbb016fb6ff8b4f418641ac05a9b2fcc)
|
|
|
|
Co-authored-by: Gregory P. Smith <greg@krypto.org>
|
|
---
|
|
Lib/test/test_httplib.py | 7 ++++++-
|
|
1 file changed, 6 insertions(+), 1 deletion(-)
|
|
|
|
diff --git a/Lib/test/test_httplib.py b/Lib/test/test_httplib.py
|
|
index 8333aa0eeef6a..a65044eea60dc 100644
|
|
--- a/Lib/test/test_httplib.py
|
|
+++ b/Lib/test/test_httplib.py
|
|
@@ -1004,7 +1004,12 @@ def test_overflowing_header_limit_after_100(self):
|
|
'r\n' * 32768
|
|
)
|
|
resp = client.HTTPResponse(FakeSocket(body))
|
|
- self.assertRaises(client.HTTPException, resp.begin)
|
|
+ with self.assertRaises(client.HTTPException) as cm:
|
|
+ resp.begin()
|
|
+ # We must assert more because other reasonable errors that we
|
|
+ # do not want can also be HTTPException derived.
|
|
+ self.assertIn('got more than ', str(cm.exception))
|
|
+ self.assertIn('headers', str(cm.exception))
|
|
|
|
def test_overflowing_chunked_line(self):
|
|
body = (
|